Changeset 6919 for source/ariba/overlay/modules

Timestamp:

Nov 13, 2009, 1:41:34 PM (15 years ago)

Author:

mies

Message:

Fixed tons of warnings when using CXXFLAGS="-Wall"!

Location:

source/ariba/overlay/modules

Files:

• OverlayInterface.h (modified) (2 diffs)
• chord/Chord.cpp (modified) (5 diffs)
• chord/detail/chord_routing_table.hpp (modified) (1 diff)
• onehop/OneHop.cpp (modified) (1 diff)

source/ariba/overlay/modules/OverlayInterface.h

@@ -179 +179 @@
         BaseOverlay& baseoverlay;
 
-        /// The parameters of the overlay structure
-        OverlayParameterSet parameters;
-
         /// The node identifier to use with this overlay
         const NodeID& nodeid;
@@ -187 +184 @@
         /// The listener used to inform about overlay structure changes
         OverlayStructureEvents* eventsReceiver;
+
+        /// The parameters of the overlay structure
+        OverlayParameterSet parameters;
 
         /// The service identifer of this overlay

source/ariba/overlay/modules/chord/Chord.cpp

@@ -79 +79 @@
 
         // check if we already have a connection
-        for (int i=0; i<table->size(); i++)
+        for (size_t i=0; i<table->size(); i++)
                 if ((*table)[i]->ref_count > 0 && (*table)[i]->id == remote && !((*table)[i]->info.isUnspecified()))
                         return LinkID::UNSPECIFIED;
@@ -291 +291 @@
 
         // handle messages
-        switch (m->getType()) {
+        switch ((signalMessageTypes)m->getType()) {
 
         // discovery request
@@ -317 +317 @@
                         setup( dmsg->getEndpoint(), m->getSourceNode() );
 
-                // delegate discovery message
+                // process discovery message -------------------------- switch start --
                 switch (dmsg->getType()) {
 
@@ -388 +388 @@
                         baseoverlay.send(&omsg, omsg.getDestinationNode());
                         break;
-                }}
+                }
+                case Discovery::invalid:
+                        break;
+
+                default:
+                        break;
+                }
+                // process discovery message ---------------------------- switch end --
+
                 delete dmsg;
                 break;
@@ -426 +434 @@
                 // updating neighbors
                 logging_debug("Discover new ring neighbors");
-                for (int i=0; i<table->size(); i++) {
+                for (size_t i=0; i<table->size(); i++) {
                         LinkID id = (*table)[i]->info;
                         if (!id.isUnspecified()) discover_neighbors(id);

source/ariba/overlay/modules/chord/detail/chord_routing_table.hpp

@@ -92 +92 @@
 private:
         // maximum number of fingers
-        static const int max_fingers = 32;
+        static const size_t max_fingers = 32;
 
         // the own node id

source/ariba/overlay/modules/onehop/OneHop.cpp

@@ -241 +241 @@
         if( onemsg->isType( OneHopMessage::OneHopMessageTypeListingRequest ) ){
 
-                NodeListingRequest* request = onemsg->decapsulate<NodeListingRequest>();
+                //NodeListingRequest* request = onemsg->decapsulate<NodeListingRequest>();
 
                 logging_info( "onehop received node listing request from node " << remote.toString() );