Changeset 12060 for source/ariba/CommunicationListener.cpp

Timestamp:

Jun 19, 2013, 11:05:49 AM (11 years ago)

Author:

hock@…

Message:

Reintegrate branch: 20130111-hock-message_classes

improvements:

• new message classes (reboost, zero-copy)
• "fast path" for direct links (skip overlay layer)
• link-properties accessible from the application
• SystemQueue can call boost::bind functions
• protlib compatibility removed (32bit overhead saved in every message)
• addressing2
• AddressDiscovery discoveres only addresses on which we're actually listening
• ariba serialization usage reduced (sill used in OverlayMsg)
• Node::connect, easier and cleaner interface to start-up ariba from the application
• ariba configs via JSON, XML, etc (boost::property_tree)
• keep-alive overhead greatly reduced
• (relayed) overlay links can actually be closed now
• lost messages are detected in most cases
• notification to the application when link is transformed into direct-link
• overlay routing: send message to second best hop if it would be dropped otherwise
• SequenceNumbers (only mechanisms, so for: upward compatibility)
• various small fixes

regressions:

• bluetooth is not yet working again
• bootstrap modules deactivated
• liblog4xx is not working (use cout-logging)

This patch brings great performance and stability improvements at cost of backward compatibility.
Also bluetooth and the bootstrap modules have not been ported to the new interfaces, yet.

File:

• source/ariba/CommunicationListener.cpp (modified) (2 diffs)

source/ariba/CommunicationListener.cpp

@@ -59 +59 @@
 
 void CommunicationListener::onLinkFail(const LinkID& l, const NodeID& r) {
+    onLinkDown(l, r);
 }
 
@@ -69 +70 @@
 }
 
+// this implementation provides backward compatibility
+// overwrite it to use the new interface
+void CommunicationListener::onMessage(reboost::shared_buffer_t message,
+        const NodeID& remote,
+        const LinkID& lnk,
+        const SequenceNumber& seqnum,
+        const ariba::overlay::OverlayMsg* overlay_msg)
+{
+    // copy data
+    Data data;
+    data.setLength(message.size() * 8);
+    memcpy(data.getBuffer(), message.data(), message.size());
+    
+    // and prepare old-style overlay message
+    Message legacy_msg;
+    legacy_msg.setPayload(data);
+    
+    
+    // * call legacy handler *
+    this->onMessage(legacy_msg, remote, lnk);
+}
+
 void CommunicationListener::onKeyValue( const Data& key, const vector<Data>& value ) {
 }
 
+bool CommunicationListener::onPing(const NodeID& remote)
+{
+    return true;
+}
+
+void CommunicationListener::onPingLost(const NodeID& remote)
+{
+}
+
+void CommunicationListener::onPong(const NodeID& remote)
+{
+}
+
 } // namespace ariba