Changeset 12764 for tests/SystemQueue-tests.cc

Timestamp:

Mar 14, 2014, 7:58:45 PM (10 years ago)

Author:

hock@…

Message:

New SystemQueue...

... is passing all unit tests, now. :-)

File:

• tests/SystemQueue-tests.cc (modified) (7 diffs)

tests/SystemQueue-tests.cc

@@ -99 +99 @@
     void Cancel()
     {
-        cout << "### Cancel ### "<< endl;
-
-        SystemQueue::instance().cancel();
+        ASSERT_THROW(SystemQueue::instance().cancel(), std::logic_error);
+        
         checkmark = true;
     }
@@ -194 +193 @@
 /**
  *  cancels the SystemQueue from inside a scheduled event
+ * 
+ *  --> and expects that this throws an exception
+ * 
+ *  NOTE: due to the SystemQueue singleton design, explicit cleanup is necessary!
  */
 TEST_F(SystemQueueTest, CancelFromInsideEvent)
@@ -211 +214 @@
     wait_for_checkmark(MAX_WAIT);
 
-    EXPECT_FALSE( sysq.isRunning() ) << "SystemQueue has not stopped properly.";
-    EXPECT_TRUE( sysq.isEmpty() ) << "SystemQueue has not stopped properly.";
+    // CLEANUP
+    sysq.cancel();
+    
+    EXPECT_FALSE( sysq.isRunning() );
+    EXPECT_TRUE( sysq.isEmpty() );
 }
 
@@ -343 +349 @@
  */
 #define DELAY_TIME 20  // ms
-#define DELAY_MARGIN 2000  // microseconds (1/1000 ms)   // TODO maybe this is too much..
+#define DELAY_MARGIN 1000  // microseconds (1/1000 ms)   // NOTE: maybe a meaningful value depends
+                                                         // on the target hardwarde and system load...
 
 
@@ -406 +413 @@
 
     // noting to do until the delay is up..
-    usleep(DELAY_TIME*1000 + DELAY_MARGIN*10);  // XXX margin too high (TODO lower when SysQ is reimplemented)
+    usleep(DELAY_TIME*1000 + DELAY_MARGIN*10);
     
     // wait for the event to happen
@@ -475 +482 @@
 
     // noting to do until the delay is up..
-    usleep(DELAY_TIME * 4000 + DELAY_MARGIN*100);  // XXX margin too high
+    usleep(DELAY_TIME * 4000 + DELAY_MARGIN*10);
     
     // wait for the event to happen
@@ -544 +551 @@
  * TODO
  * 
- * maybe one more complicated testcall with timing and directly scheduled events
+ * maybe one more complicated testcase with timing and directly scheduled events
  * 
  * but this probably only makes sense after a working SysQ implementation exists..