Changeset 12771

Timestamp:

Mar 19, 2014, 6:41:45 PM (11 years ago)

Author:

hock@…

Message:

added new interface: SystemQueue::am_I_in_the_SysQ_thread

for debugging and asserts..

Files:

• source/ariba/utility/system/SystemQueue.cpp (modified) (2 diffs)
• source/ariba/utility/system/SystemQueue.h (modified) (1 diff)
• tests/SystemQueue-tests.cc (modified) (2 diffs)

source/ariba/utility/system/SystemQueue.cpp

@@ -117 +117 @@
 {
     // CHECK: this function must not be called from within a SystemQueue-Event
-    if ( sysq_thread && boost::this_thread::get_id() == sysq_thread->get_id() )
+    if ( am_I_in_the_SysQ_thread() )
+//     if ( sysq_thread && boost::this_thread::get_id() == sysq_thread->get_id() )
     {
         logging_warn("SystemQueue::cancel() was called from within a SystemQueue-Event. This is not allowed!");
@@ -179 +180 @@
 {
     return SysQ->isRunning();
+}
+
+bool SystemQueue::am_I_in_the_SysQ_thread()
+{
+    return sysq_thread && boost::this_thread::get_id() == sysq_thread->get_id();
 }
 

source/ariba/utility/system/SystemQueue.h

@@ -161 +161 @@
          * Is the system queue already started and running?
          *
-         * @return True, if the system queue is running.
+         * @return TRUE, if the system queue is running. | FALSE otherwise
          */
         bool isRunning();
+    
+    /**
+     *  NOTE: This function is for debugging and asserts only!!
+     * 
+     *  @return TRUE if called from the SysQ thread (from inside a SystemEvent)
+     *          | FALSE if it's called from another thread
+     */
+    bool am_I_in_the_SysQ_thread();
 
 protected:

tests/SystemQueue-tests.cc

@@ -94 +94 @@
         cout << "### Check ### "<< endl;
 
+        checkmark = true;
+    }
+
+    void CheckThread()
+    {
+        EXPECT_TRUE( SystemQueue::instance().am_I_in_the_SysQ_thread() );
+        
         checkmark = true;
     }
@@ -345 +352 @@
 }
 
+
+TEST_F(SystemQueueTest, ThreadDetection)
+{
+    SystemQueue& sysq = SystemQueue::instance();
+    
+    // start
+    sysq.run();
+    
+    EXPECT_FALSE( sysq.am_I_in_the_SysQ_thread() );
+    
+    // scheduleCall
+    sysq.scheduleCall(
+        boost::bind(&SystemQueueTest::CheckThread, this)
+    );
+    
+    wait_for_checkmark(MAX_WAIT);
+    
+    sysq.cancel();
+    
+    EXPECT_TRUE( checkmark ) << "WARNING! One of the test functions was not called at all!";
+}
+
+
 /**
  *  schedule multiple calls